Conversation
📝 WalkthroughWalkthroughThis pull request updates release documentation and Go module dependencies. The CHANGELOG.md is modified to document v1.0.0 as stable and identical to v1.0.0-rc.5, while the EVM module's go.mod disables an active replace directive and updates a dependency version from rc.3 to rc.4. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 1m 6s —— View job Code Review
This is a clean, focused release prep PR. Here's the review: CHANGELOG.mdThe split of Minor observation: The phrasing ## v1.0.0
Stable release. No code changes from v1.0.0-rc.5.This is purely stylistic — not a blocker. apps/evm/go.modCommenting out replace directives ( Potential inconsistency ( Bump of SummaryThe changes are minimal and well-scoped. The one item worth verifying before merging: should |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/evm/go.mod`:
- Around line 5-14: The go.mod currently requires github.com/evstack/ev-node
v1.0.0-rc.5 but pins github.com/evstack/ev-node/execution/evm at v1.0.0-rc.4;
re-align them by either updating the execution/evm require to v1.0.0-rc.5 or, if
v1.0.0-rc.5 isn’t published yet, re-enable the local replace block that points
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to the
sibling workspace so the module builds against the in-repo rc.5 execution code.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cf59bd2-d62a-4203-9589-f2644523edcb
⛔ Files ignored due to path filters (1)
apps/evm/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
CHANGELOG.mdapps/evm/go.mod
| //replace ( | ||
| // github.com/evstack/ev-node => ../../ | ||
| // github.com/evstack/ev-node/execution/evm => ../../execution/evm | ||
| //) | ||
|
|
||
| require ( | ||
| github.com/ethereum/go-ethereum v1.17.0 | ||
| github.com/evstack/ev-node v1.0.0-rc.5 | ||
| github.com/evstack/ev-node/core v1.0.0 | ||
| github.com/evstack/ev-node/execution/evm v1.0.0-rc.3 | ||
| github.com/evstack/ev-node/execution/evm v1.0.0-rc.4 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== apps/evm/go.mod =="
sed -n '1,25p' apps/evm/go.mod
echo
echo "== execution/evm/go.mod =="
sed -n '1,20p' execution/evm/go.mod
echo
echo "== workspace files =="
fd '^go\.work(\.example)?$' -a
echo
echo "== version pins for ev-node/execution/evm across go.mod files =="
rg -n --glob 'go.mod' 'github\.com/evstack/ev-node/execution/evm v'Repository: evstack/ev-node
Length of output: 1873
Align apps/evm with the rc.5 execution module before cutting this release.
Line 14 pins github.com/evstack/ev-node/execution/evm to v1.0.0-rc.4 while this module already depends on github.com/evstack/ev-node v1.0.0-rc.5. With the local replace block disabled (lines 5-8), apps/evm will resolve the published rc.4 execution module instead of the in-repo sibling, causing this PR to be built and validated against older execution code than the release describes.
Suggested fix
-//replace (
-// github.com/evstack/ev-node => ../../
-// github.com/evstack/ev-node/execution/evm => ../../execution/evm
-//)
+replace (
+ github.com/evstack/ev-node => ../../
+ github.com/evstack/ev-node/execution/evm => ../../execution/evm
+)
@@
- github.com/evstack/ev-node/execution/evm v1.0.0-rc.4
+ github.com/evstack/ev-node/execution/evm v1.0.0-rc.5If v1.0.0-rc.5 is not published yet, keep the local replace active until it is.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/evm/go.mod` around lines 5 - 14, The go.mod currently requires
github.com/evstack/ev-node v1.0.0-rc.5 but pins
github.com/evstack/ev-node/execution/evm at v1.0.0-rc.4; re-align them by either
updating the execution/evm require to v1.0.0-rc.5 or, if v1.0.0-rc.5 isn’t
published yet, re-enable the local replace block that points
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to the
sibling workspace so the module builds against the in-repo rc.5 execution code.
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
* main: fix(syncer): include in-flight and pending-cache work in PendingCount (#3162) chore: re-add replaces for development (#3161) build(deps): Bump quinn-proto from 0.11.13 to 0.11.14 in the cargo group across 1 directory (#3155) build(deps): bump execution/evm (#3160) build(deps): bump ev-node (#3159) chore: remove replaces from ev-node (#3158) chore: fix some function names in comment (#3156) fix: persist snapshot once for avoiding badger vlog (#3153) build(deps): Bump docker/setup-buildx-action from 3 to 4 (#3148) build(deps): Bump the all-go group across 5 directories with 8 updates (#3147) build(deps): Bump docker/login-action from 3 to 4 (#3149) build(deps): Bump docker/build-push-action from 6 to 7 (#3151) build(deps): Bump actions/setup-go from 6.2.0 to 6.3.0 (#3150) chore: prep evm rc.5 (#3145) build(deps): bump ev-node (#3144) feat(block): Event-Driven DA Follower with WebSocket Subscriptions (#3131) build(deps): Bump dompurify from 3.2.6 to 3.3.2 in /docs in the npm_and_yarn group across 1 directory (#3140) feat(benchmarking): adding gas burner test (#3115) chore: minor deduplication (#3139) refactor(store,cache)!: optimize cache restore as O(1) (#3134)
Overview
Summary by CodeRabbit
Documentation
Chores